Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eye of Flügel and Gaia 2 Dice issues. #4491

Open
TurtleCage opened this issue Nov 27, 2023 · 7 comments
Open

Eye of Flügel and Gaia 2 Dice issues. #4491

TurtleCage opened this issue Nov 27, 2023 · 7 comments

Comments

@TurtleCage
Copy link

Mod Loader

Forge

Minecraft Version

1.20.1

Botania version

Botania-1.20.1-441-FORGE

Modloader version

Forge 47.2.0

Modpack info

All The Mods 9

The latest.log file

https://gist.github.com/TurtleCage/aecced642654d50d32047523b418f89b.js

Issue description

After defeating Gaia 2 and rolling the dice for Ring of Loki, it provided an Emerald Stoneplate ring from Iron's Spells
It still provided the corresponding achievement.

Eye of the Flügel's main function (warp) works fine but it does not allow for flight with the Tiara after the flight bar runs out.

Unclear if these are ATM or Botania bugs, will report there as well.

Thanks.

Steps to reproduce

1 - Defeat Gaia 2, use Dice for Ring of Loki.

2 - Attempt Flight with Tiara with Eye of Flügel, mana present in 2 forms - Mirror and Tablet and wait for flight bar to deplete.

Other information

No extra mods added or removed to the ATM9 pack.

@TheRealWormbo
Copy link
Collaborator

For reference, the ATM issue can be found here: AllTheMods/ATM-9#894

These are technically two independent bugs, likely with different causes. However, due to the nature of the mod pack (20 pages of included mods on its CurseForge page) it's next to impossible to figure out which of the mods might cause either of those issues. It might even be a customization by ATM itself.

The Dice of Fate check if the player already has certain advancements to determine whether the player has yet to obtain the corresponding item. Once all six relic advancements are obtained, it switches to picking random loot from six possible loot tables that could be customized in a data pack.

As for the Flügel Tiara and Eye of the Flügel, the tiara checks for the presence of the eye in the player's inventory. Also, it only works if the player actually has mana left. Check that the item type is actually botania:fluegel_eye (using advanced tooltips via F3+H), otherwise the tiara can't find it.

@Danoned
Copy link

Danoned commented Dec 17, 2023

Tested in vanilla + botania only modpack and I can confirm it's a botania issue. It's a issue with 1.20.1 botania version

@anoomolu
Copy link
Collaborator

anoomolu commented Dec 18, 2023

Can confirm the second issue on fabric too, you don't need both mana containers, just one is enough to reproduce

@TheRealWormbo
Copy link
Collaborator

The tiara fails to detect the eye because the method it uses to look for it tries to match NBT data to a pristine copy of the eye item. And helpfully, Mojang changed the method we used so far from matching just item type to matching type and NBT data at some point since 1.19.2.

TheRealWormbo added a commit to TheRealWormbo/Botania that referenced this issue Jan 14, 2024
Added new helper method to replicate the old behavior and used it where necessary. (i.e. Flügel Tiara check for Eye, and GoG mana flame block; fixes VazkiiMods#4530, and partially VazkiiMods#4491)
TheRealWormbo added a commit that referenced this issue Mar 17, 2024
Added new helper method to replicate the old behavior and used it where necessary. (i.e. Flügel Tiara check for Eye, and GoG mana flame block; fixes #4530, and partially #4491)
TheRealWormbo added a commit to TheRealWormbo/Botania that referenced this issue Apr 30, 2024
TheRealWormbo added a commit that referenced this issue Apr 30, 2024
@TheRealWormbo
Copy link
Collaborator

The Flügel Tiara/Eye of the Flügel issue should be fixed in 1.20.1-444.
There also has been a fix for loot table handling, of which I'm not sure whether it potentially fixed the Dice of Fate rolling issue mentioned here. Can someone confirm if that still happens in the latest release?

@TheBedrockMaster
Copy link

Was there any update on this?

@TheRealWormbo
Copy link
Collaborator

We have not yet looked into ATM-9. But TBH, it giving a different item and yet granting the advancement sounds like it's not a Botania issue. That advancement is not tied to the Guardian of Gaia or the dice roll, but to actually obtaining the Ring of Loki. If another item grants that advancement, then it might be something in the mod providing that item or in the mod pack combining that mod with Botania, because these things can be adjusted in data packs and through code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants