Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All crafted botania flowers are a target for comparators #4741

Closed
jmeansta opened this issue Aug 19, 2024 · 3 comments · Fixed by #4745
Closed

All crafted botania flowers are a target for comparators #4741

jmeansta opened this issue Aug 19, 2024 · 3 comments · Fixed by #4745
Labels
1.20.1 Issue has been reported for version 1.20.1 of Minecraft bug A bug confirmed The maintainers will take a look at this.

Comments

@jmeansta
Copy link

Mod Loader

Forge

Minecraft Version

1.20.1

Botania version

1.20.1-445

Modloader version

47.3.0

Modpack info

No response

The latest.log file

https://gist.github.com/jmeansta/69fc7421c29a23d712801106f90032b1

Issue description

Functional and generating flora are targets for redstone comparator. This means that the red stringed comparator mistakenly binds to these flowers.
redStringBug
Shimmering mushrooms, mystical flowers, and glimmering flowers do not display this incorrect binding.
Floating flowers and flowers placed on dirt-like blocks display the same behavior.

Steps to reproduce

  1. Place a functional or generating flower other than the thermalily
  2. Place a red stringed comparator pointed towards the flower
  3. Hold a wand of the forest and look at the red stringed comparator. The "red string" and rainbow binding box should appear around the flower, indicating that it is the target of the red stringed comparator

Other information

This bug was filed in response to the following conversation on the Violet Moon discord server: https://discord.com/channels/154261184701267969/1079855089767952496/1274970503802785792
@ggkkaa
Copy link

ggkkaa commented Aug 19, 2024

Hey, If anyone here is a dev, I'm a new dev trying to fix this issue, so can someone tell me where is thhe red stringed comparator defined?

@TheRealWormbo
Copy link
Collaborator

The red-stringed comparator is not the issue, as the vanilla redstone comparator will also attempt to read a signal from flowers, even though a solid block. This needs to be fixed in the special flower block and block entity classes.

@TheRealWormbo TheRealWormbo added bug A bug confirmed The maintainers will take a look at this. 1.20.1 Issue has been reported for version 1.20.1 of Minecraft labels Aug 22, 2024
@TheRealWormbo
Copy link
Collaborator

I think the fix that would make the most sense would be a boolean constructor parameter on the three block type classes used by special flowers (FloatingSpecialFlowerBlock, FabricSpecialFlowerBlock, and ForgeSpecialFlowerBlock) that tells the block if it should advertise the availability of a comparator signal, since there's no block entity reference where that info needs to be available.
That's an (internal) API change, so not sure if that's something to change in the 1.20 version.

TheRealWormbo added a commit to TheRealWormbo/Botania that referenced this issue Aug 31, 2024
@TheRealWormbo
Don't output a comparator signal for flowers that don't actually have…
e032274 
… one

- fixes VazkiiMods#4741 (non-Thermalily special/floating flowers having comparator output zero)
- also fixes breaking a Thermalily not resetting a comparator output that was read through a solid block
@TheRealWormbo TheRealWormbo mentioned this issue Aug 31, 2024
Merged
TheRealWormbo added a commit that referenced this issue Dec 13, 2024
@TheRealWormbo
Don't output a comparator signal for flowers that don't actually have…
333c14b 
… one

- fixes #4741 (non-Thermalily special/floating flowers having comparator output zero)
- also fixes breaking a Thermalily not resetting a comparator output that was read through a solid block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.20.1 Issue has been reported for version 1.20.1 of Minecraft bug A bug confirmed The maintainers will take a look at this.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't output a comparator signal for flowers that don't actually have one TheRealWormbo/Botania
3 participants
@TheRealWormbo @jmeansta @ggkkaa