Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SharedCache] Limit sections being added in SharedCache::InitializeHeader to the regions being loaded #6459

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

WeiN76LQh
Copy link

The logic before would default to adding a section unless it was from a region in the regionsToLoad argument and its header had already been initialized. However if a user does Load Section by Address then there's only one region in regionsToLoad. All sections not in that region would be automatically added, even if they had already been or the user hadn't requested them to be loaded.

…eader` to the regions being loaded

The logic before would default to adding a section unless it was from a region in the `regionsToLoad` argument and its header had already been initialized. However if a user does `Load Section by Address` then there's only one region in `regionsToLoad`. All sections not in that region would be automatically added, even if they had already been or the user hadn't requested them to be loaded.
@WeiN76LQh
Copy link
Author

I actually wanted to do a lot more with this PR in regards to section loading but I'm unsure what the desire is and a reasonable amount of code will need modifying.

Currently the user can Load Section by Address with a right-click action but this is misleading as it results in a segment being loaded which can load multiple sections, in some cases, quite a few. Also when right-clicking a address for memory which has not been loaded the user is offered to load a segment not a section.

It makes sense to be more granular as some segments do contain a number of sections but this will realistically require the metadata to be modified to track when a memory region (representing an image segment) has only be partially loaded due to not all of its sections being loaded.

I think either Load Section by Address should become Load Segment by Address, to more accurately represent what will happen, or the code should be modified to only load a section. The latter, to me, is more desireable. Additionally it would make sense to modify the right-click on an unloaded memory address to offer to load a section rather than a segment.

This is personal opinion so it would be good to hear what the devs think o this before I push a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant