Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add themetoggle #7

Merged
merged 16 commits into from
Apr 14, 2023
Merged

Add themetoggle #7

merged 16 commits into from
Apr 14, 2023

Conversation

ggtylerr
Copy link
Contributor

@ggtylerr ggtylerr commented Apr 13, 2023

Adds a cool theme switcher:

vencordthemeswitcher.mp4

  • Also moves the download link to the right (Redesign issues!! #6)
  • Style code is messy, I know, lol
  • Moving between pages / sites causes it to briefly load the initial color scheme
    • This is because the script loads after the page content does and I have no idea how to fix that
    • This is fixed in the 6th commit here
  • Also the theme switcher is on the bottom right to align with the other icons. Tried it with the top right and it looked ugly. It can be moved pretty easily so it isn't too much of a problem.

@vercel
Copy link

vercel bot commented Apr 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vencord-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 0:30am

Copy link
Member

@lewisakura lewisakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the colors? The purple accent is wrong and it seems like at least one of the background colors is incorrect (see how the inline code looks on the download page dark vs light) nevermind this is how it was.

@ggtylerr
Copy link
Contributor Author

Yeah there shouldn't be any color changes, I just moved everything to different variables

@ggtylerr
Copy link
Contributor Author

Nevermind I'm an idiot and forgot to change 2 of the var -> theme var lines

src/components/Footer.astro Outdated Show resolved Hide resolved
src/components/Footer.astro Outdated Show resolved Hide resolved
src/components/Theme.svelte Outdated Show resolved Hide resolved
src/components/Theme.svelte Outdated Show resolved Hide resolved
src/layouts/Layout.astro Outdated Show resolved Hide resolved
@Vendicated Vendicated changed the title Add a theme switcher Add themetoggle Apr 14, 2023
@Vendicated Vendicated merged commit 946482b into Vencord:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants