Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate job code loading from app.py #20

Open
4 tasks
jonulak opened this issue Nov 19, 2024 · 1 comment · May be fixed by #23
Open
4 tasks

Separate job code loading from app.py #20

jonulak opened this issue Nov 19, 2024 · 1 comment · May be fixed by #23
Assignees

Comments

@jonulak
Copy link
Contributor

jonulak commented Nov 19, 2024

Data Loading Refactor: Extract Data Loading Logic from app.py

Type: Refactor
Priority: Medium

Description

Move data loading logic from app.py into a dedicated module to improve code organization and maintain separation of concerns.

Current State

  • Data loading logic for MOS data and VWC path mapping is currently located in app.py
  • This violates separation of concerns and makes the main application file more complex than necessary

Required Changes

  1. Create new file data/data_loader.py
  2. Extract data loading functions from app.py into data_loader.py
  3. Update app.py to import the necessary functions from data_loader
  4. Run existing test suite to verify data loading functionality remains intact

Files Affected

  • app.py (modify)
  • data/data_loader.py (create)

Acceptance Criteria

  • All data loading logic moved to data_loader.py
  • app.py imports and uses functions from data_loader
  • All existing tests pass
  • No changes to current data loading behavior
@jeromehardaway
Copy link
Collaborator

jeromehardaway commented Nov 20, 2024

Consider adding these changes:

Data Loading Refactor: Extract Data Loading Logic from app.py

Type: Refactor
Priority: Medium

Description

Move data loading logic from app.py into a dedicated module to improve code organization and maintain separation of concerns.

Current State

  • Data loading logic for MOS data and VWC path mapping is currently located in app.py
  • This violates separation of concerns and makes the main application file more complex than necessary

Required Changes

  1. Create new file data/data_loader.py
  2. Extract data loading functions from app.py into data_loader.py
  3. Update app.py to import the necessary functions from data_loader
  4. Run existing test suite to verify data loading functionality remains intact

Files Affected

  • app.py (modify)
  • data/data_loader.py (create)

Acceptance Criteria

  • All data loading logic moved to data_loader.py
  • app.py imports and uses functions from data_loader
  • All existing tests pass
  • No changes to current data loading behavior

@jonulak jonulak self-assigned this Nov 21, 2024
@jonulak jonulak added this to VetsAI Nov 21, 2024
@jonulak jonulak moved this to Todo in VetsAI Nov 21, 2024
@jonulak jonulak linked a pull request Nov 22, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants