Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add a setting to disable Spotify API completely #10

Open
ginqus opened this issue Nov 25, 2024 · 4 comments
Open

[Feature request] Add a setting to disable Spotify API completely #10

ginqus opened this issue Nov 25, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@ginqus
Copy link

ginqus commented Nov 25, 2024

I'm from a country that's geoblocked by Spotify. Because of that, Spotify API usage is impossible (without a VPN), and the genres don't show at all.

The main issue I'm facing is the fact that the extension, even if using LastFM as a genre provider, uses Spotify API to create hyperlinks that point to The Sounds Of Spotify playlists for the genres (or at least I assume it does from the code). Because of this, the genres cannot be shown.

So, it would be useful to have an option to disable the hyperlinks, or maybe display the genres without hyperlinks if api.spotify.com search fails.

I'm sorry if I made some false assumptions, I know nothing about TypeScript, but I've modified the code ("ChatGPT modified it for me" is more correct though), and the genres now show up (without hyperlinks). Here's the build, I'll upload the code later.

Thank you for the extension and your hard work!

@Vexcited Vexcited added the enhancement New feature or request label Nov 25, 2024
@Vexcited
Copy link
Owner

Hello ! Thanks for the suggestions, can you maybe push the modifications in a pull request so we can review the code together ?

@ginqus
Copy link
Author

ginqus commented Nov 25, 2024

Hello ! Thanks for the suggestions, can you maybe push the modifications in a pull request so we can review the code together ?

Well, I simply removed Spotify API from the code altogether, just so that it could work for me, so a pull request is too much. But I can make a fork later once I get home and link it. It's a very dirty workaround and it doesn't allow switching between LastFM and Spotify API.

@ginqus
Copy link
Author

ginqus commented Nov 25, 2024

Here, I've created a fork: https://github.com/ginqus/better-spotify-genres-lastfm

I don't want to make a PR because my fork removes Spotify API completely, the user can't control this. I would love to help you, but unfortunately I have never worked with TypeScript before, so all I can do is kindly ask you to implement what I described previously. There's no hurry of course, I understand that debugging something to work in a country with sanctions, while not being in said country can be frustrating, so it's just a suggestion. It's fine if you decide not to add this, too. Thank you either way :)

@Vexcited
Copy link
Owner

Sure! I'm going to let this issue open in case I get some time to work on this, thanks you!

@Vexcited Vexcited pinned this issue Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants