Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Bundle Status #981

Open
MadeWilson opened this issue Aug 11, 2017 · 0 comments
Open

Filter Bundle Status #981

MadeWilson opened this issue Aug 11, 2017 · 0 comments

Comments

@MadeWilson
Copy link
Contributor

Description

Today the FilterBundle is part of victoire and have only one purpose.
He provide some base class to facilitate the creatio of Filter class.
Filter class who are only use in conjunction with the widget filter and listings.

The first issue with that, is the fact that we have an business stack that will
never interact with victoire and is bnudle, unneless with the right widget. This logic
shouldn't be located directly in this widget.

The second being the structure of the Filter class, they all implement to method buildForm
and buildQuery.
bundleForm make sens since this class is based on the AbstractType class from symfony.
But buildQuery is called to construct the query who will bring the result of the filter action on the filter widget.

Then we should conserve the filter class for the widget filter content resolver need who are to display a form.
And create a new type of class filter who are made to talk with widget listing content resolver in order
to filtrate the list.

Resolution Ideas

Dont no yet

Related to

Bundle -- -- --
Analytics Page
Blog Query
BusinessEntity Seo
BusinessPage Sitemap
Core Template
Criteria Twig
Filter X User
Form ViewReference
I18n Widget
Media WidgetMap
UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant