Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/email notifications #4

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Feature/email notifications #4

wants to merge 18 commits into from

Commits on Nov 28, 2018

  1. [logic][s]: custom validator for state - refs #12

    @zelima
    zelima committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    b49437e View commit details
    Browse the repository at this point in the history

  2. [views][m]: Note for editors - refs #12

    @zelima
    zelima committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    b8cba5a View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2018

  1. [search][s]: don't show pending packages. refs #12

    @zelima
    zelima committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    75395d5 View commit details
    Browse the repository at this point in the history

  2. [showcase][s]: restrict anonimous users - refs #12

    @zelima
    zelima committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    609c793 View commit details
    Browse the repository at this point in the history

  3. merge master for working tests

    @zelima
    zelima committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    0f6cccc View commit details
    Browse the repository at this point in the history

  4. [tests][m]: fix broken tests - refs #12 

    - pass the context to get popular and recently viewed datasets
- update test to pass user name to context
- update layout1 to pass username to helper
- new test case  to cehck only approved datasets are listed
    @zelima
    zelima committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    daadd48 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2018

  1. [tests][s]: test get_admin

    @zelima
    zelima committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    8e63b69 View commit details
    Browse the repository at this point in the history

  2. [tests][s]: test validators

    @zelima
    zelima committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    5e8417e View commit details
    Browse the repository at this point in the history

  3. [tests][s]: test package_show

    @zelima
    zelima committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    4ea13ff View commit details
    Browse the repository at this point in the history

  4. [tidy][m]: tidy logic and code 

    - get rid of approved
- correct role for readers
    @zelima
    zelima committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    a7de217 View commit details
    Browse the repository at this point in the history

  5. Make validator logic more robust

    @amercader
    amercader committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    5e1c335 View commit details
    Browse the repository at this point in the history

  6. Fix auth check in package_show

    @amercader
    amercader committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    1460cb6 View commit details
    Browse the repository at this point in the history

  7. Fix tests 

    call_action sets ignore_auth=True by default, which basically means that
everybody can `package_update`, so the the check on `package_show`
doesn't work. Also simplified the tests when possible.
    @amercader
    amercader committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    1ac9211 View commit details
    Browse the repository at this point in the history

  8. [tests][m]: tests for each role

    @zelima
    zelima committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    3f8d225 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2018

  1. [tests][s]: state pending for updated packages

    @zelima
    zelima committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    5d296b0 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2018

  1. [search][s]: use IPackageController.before_search

    @zelima
    zelima committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    8edd1ad View commit details
    Browse the repository at this point in the history

  2. [updated datasets][s]: get rid of package_show

    @zelima
    zelima committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    9f0d999 View commit details
    Browse the repository at this point in the history

  3. [emails][m]: email admins re pending pkgs refs #13 

    - override package_create to send email if approval_pending
- Email template including info about package, user and admin
- tests
    @zelima
    zelima committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    e384084 View commit details
    Browse the repository at this point in the history