From 57dfe1d7ccc82081fa0e7d08ecc2a0f65a021352 Mon Sep 17 00:00:00 2001 From: Eitot Date: Tue, 6 Jun 2023 11:26:56 +0200 Subject: [PATCH 1/2] Replace deprecated method --- Vienna/Sources/Application/AppController.m | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/Vienna/Sources/Application/AppController.m b/Vienna/Sources/Application/AppController.m index c7d4e07cac..fda64b7aeb 100644 --- a/Vienna/Sources/Application/AppController.m +++ b/Vienna/Sources/Application/AppController.m @@ -909,10 +909,16 @@ -(IBAction)downloadEnclosure:(id)sender /* openVienna * Calls into showMainWindow but activates the app first. */ --(IBAction)openVienna:(id)sender +- (IBAction)openVienna:(id)sender { - [NSApp activateIgnoringOtherApps:YES]; - [self showMainWindow:sender]; + if (@available(macOS 14, *)) { + [NSApp activate]; + } else { + [NSApp activateIgnoringOtherApps:YES]; + } + if (NSApp.isActive) { + [self showMainWindow:sender]; + } } /* showMainWindow From c9ea9985b8f9fcff35f608966e001a42bd67e334 Mon Sep 17 00:00:00 2001 From: Eitot Date: Mon, 24 Jun 2024 00:48:47 +0200 Subject: [PATCH 2/2] Fix GitHub Action --- .github/workflows/xcodebuild.yml | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/.github/workflows/xcodebuild.yml b/.github/workflows/xcodebuild.yml index 31896a62c6..ed57f1130e 100644 --- a/.github/workflows/xcodebuild.yml +++ b/.github/workflows/xcodebuild.yml @@ -13,11 +13,14 @@ jobs: test: strategy: matrix: - os: [macos-13, macos-14] + include: + - os: macos-13 + xcode: /Applications/Xcode_15.2.app/Contents/Developer + - os: macos-14 name: Test on ${{ matrix.os }} runs-on: ${{ matrix.os }} env: - DEVELOPER_DIR: /Applications/Xcode_14.3.app/Contents/Developer + DEVELOPER_DIR: ${{ matrix.xcode }} timeout-minutes: 15 steps: @@ -26,6 +29,10 @@ jobs: with: fetch-depth: 0 - name: Build Xcode project - run: xcodebuild build-for-testing -project Vienna.xcodeproj -scheme Vienna -configuration Development | xcpretty && exit ${PIPESTATUS[0]} + run: | + xcodebuild -version + xcodebuild build-for-testing -project Vienna.xcodeproj -scheme Vienna -configuration Development | xcpretty && exit ${PIPESTATUS[0]} - name: Test Xcode project - run: xcodebuild test -project Vienna.xcodeproj -scheme Vienna -configuration Development | xcpretty && exit ${PIPESTATUS[0]} + run: | + xcodebuild -version + xcodebuild test -project Vienna.xcodeproj -scheme Vienna -configuration Development | xcpretty && exit ${PIPESTATUS[0]}