Improve handling of FoldersTree manual sort issues #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might also help with issue #1742 |
Eitot
reviewed
Jun 23, 2024
Implement a less crude way to recover when ‑loadTree:rootNode: returns NO: reattach missing folders directly under the root folder. Expected to improve on issue ViennaRSS#1743 : Vienna abruptly auto-sorts folders in the alphabetical order on the left panel
barijaona
changed the title
|
In this new attempt, I implemented a less crude way to recover when |
Eitot
approved these changes
Jun 26, 2024
|
Thanks. We just have to keep an eye on this. |
barijaona
added a commit
to barijaona/vienna-rss
that referenced
this pull request
Jul 21, 2024
Having feed sorted by names rather than by folder ID would be more user friendly. Follow-up of PR ViennaRSS#1754, working on issue ViennaRSS#1768
barijaona
added a commit
to barijaona/vienna-rss
that referenced
this pull request
Jul 28, 2024
Having feed sorted by names rather than by folder ID would be more user friendly. Follow-up of PR ViennaRSS#1754, working on issue ViennaRSS#1768
barijaona
added a commit
that referenced
this pull request
Aug 15, 2024
Improvements to folders tree (v2) - Revert PR #1754 handling of FoldersTree manual sort issues - Implement a better handling of siblings reported as missing in -loadTree:rootNode: - Check -setParent:forFolder: and -setNextSibling:folderFromID:forFolder: success or failure before moving a tree node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix issue #1743 : Vienna abruptly auto-sorts folders in the alphabetical order on the left panel