Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find swiftlint when it is in an alternate location #1757

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Find swiftlint when it is in an alternate location #1757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Vienna.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1993,7 +1993,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "if which swiftlint >/dev/null; then\n swiftlint --lenient\nelse\n echo \"warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint\"\nfi\n";
shellScript = "export PATH=/opt/homebrew/bin:/sw/bin:/opt/local/bin:/usr/local/bin:${PATH}\n\nif which swiftlint >/dev/null; then\n swiftlint --lenient\nelse\n echo \"warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint\"\nfi\n";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
shellScript = "export PATH=/opt/homebrew/bin:/sw/bin:/opt/local/bin:/usr/local/bin:${PATH}\n\nif which swiftlint >/dev/null; then\n swiftlint --lenient\nelse\n echo \"warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint\"\nfi\n";
shellScript = "PATH=${PATH}:/opt/homebrew/bin:/opt/local/bin:/sw/bin\n\nif which swiftlint >/dev/null; then\n swiftlint --lenient\nelse\n echo \"warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint\"\nfi\n";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably safer to keep the system paths at the start, in case the user installed something else that collides with a system component. /usr/local/bin is already in the default PATH.

showEnvVarsInLog = 0;
};
F6B123401E474EC500973699 /* Index Help Book */ = {
Expand Down
Loading