Course and Course Item API Rewrite #19
Conversation
src/operations/course.ts
Outdated
| if (!course) { | ||
| throw new Error('Course not found'); | ||
| } |
There was a problem hiding this comment.
could this be removed if we were to instead use findFirstOrThrow? it sounds like then an error would be automatically thrown if the course isn't found. but this totally works!
There was a problem hiding this comment.
I think what Isaiah says here about findFirstOrThrow might be a good choice since that is all we are doing with our check anyways
src/operations/course.ts
Outdated
| } catch (e) { | ||
| throw new Error('Course not found'); | ||
| } | ||
| }; |
There was a problem hiding this comment.
newline at end of file
src/operations/course.ts
Outdated
| if (!course) { | ||
| throw new Error('Course not found'); | ||
| } |
There was a problem hiding this comment.
I think what Isaiah says here about findFirstOrThrow might be a good choice since that is all we are doing with our check anyways
src/operations/course.ts
Outdated
| if (!courses) { | ||
| throw new Error('Courses not found'); | ||
| } |
There was a problem hiding this comment.
Is this check needed? My understanding of the docs is that findMany will always return a list, but this list will be empty if nothing is found.
src/operations/course.ts
Outdated
| export const getCoursesByOwnerId = async ( | ||
| ownerId: string | ||
| ): Promise<Course[]> => { |
There was a problem hiding this comment.
We should add an optional parameter here, the semesterId. I think the API will use it always but we can make it optional to make our database operations more versatile.
src/operations/course.ts
Outdated
| } | ||
| }; | ||
|
|
||
| export const getCoursesByOwnerId = async ( |
There was a problem hiding this comment.
We can probably rename this getCourses
src/operations/course.ts
Outdated
| return db.course.create({ data: course }); | ||
| }; | ||
|
|
||
| export const getCourseById = async ( |
There was a problem hiding this comment.
We can probably rename this getCourse and similar for all fns
src/operations/courseItem.ts
Outdated
| return db.courseItem.create({ data: courseItem }); | ||
| }; | ||
|
|
||
| export const getCourseItemById = async ( |
There was a problem hiding this comment.
Similar rename for the functions in this file.
src/operations/courseItem.ts
Outdated
| }; | ||
|
|
||
| export const getCourseItemsByOwnerId = async ( | ||
| ownerId: string |
There was a problem hiding this comment.
Let's add the optional parameter courseId
No description provided.