Try to add windows tests

VincentLanglet · Feb 19, 2024 · 0929cda · 0929cda
1 parent d267df9
commit 0929cda
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -8,8 +8,8 @@ on:
 
 jobs:
     test:
-        name: PHP ${{ matrix.php-version }} + ${{ matrix.dependencies }}
-        runs-on: ubuntu-latest
+        name: PHP ${{ matrix.runner }} + ${{ matrix.php-version }} + ${{ matrix.dependencies }}
+        runs-on: ${{ matrix.runner }}
 
         env:
             SYMFONY_REQUIRE: ${{matrix.symfony-require}}
@@ -22,13 +22,20 @@ jobs:
                     - 8.2
                     - 8.3
                 dependencies: [highest]
+                runner: [ubuntu-latest]
                 symfony-require: ['']
                 include:
                     - php-version: 8.0
                       dependencies: lowest
-                    - php-version: '8.2'
+                    - php-version: 8.2
                       dependencies: highest
                       symfony-require: 7.0.*
+                    - php-version: 8.2
+                      dependencies: highest
+                      runner: windows-latest
+                    - php-version: 8.2
+                      dependencies: highest
+                      runner: macos-latest
 
         steps:
             - name: Checkout

diff --git a/tests/File/FileHelperTest.php b/tests/File/FileHelperTest.php
@@ -41,6 +41,9 @@ public function testGetFileName(
         ?string $expected,
     ): void {
         static::assertSame($expected, FileHelper::getFileName($path, $baseDir, $ignoredDir));
+
+        $windowsPath = str_replace('/', '\\', $path);
+        static::assertSame($expected, FileHelper::getFileName($windowsPath, $baseDir, $ignoredDir));
     }
 
     /**
@@ -99,12 +102,15 @@ public static function getFileNameDataProvider(): iterable
      * @dataProvider getDirectoriesDataProvider
      */
     public function testGetDirectories(
-        string $absolutePath,
+        string $path,
         ?string $baseDir,
         array $ignoredDir,
         array $expected,
     ): void {
-        static::assertSame($expected, FileHelper::getDirectories($absolutePath, $baseDir, $ignoredDir, __DIR__));
+        static::assertSame($expected, FileHelper::getDirectories($path, $baseDir, $ignoredDir, __DIR__));
+
+        $windowsPath = str_replace('/', '\\', $path);
+        static::assertSame($expected, FileHelper::getDirectories($windowsPath, $baseDir, $ignoredDir, __DIR__));
     }
 
     /**