Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony 7 #145

Merged
merged 3 commits into from
Dec 3, 2023
Merged

Allow symfony 7 #145

merged 3 commits into from
Dec 3, 2023

Conversation

VincentLanglet
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3664a19) 100.00% compared to head (21f9475) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #145   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       498       498           
===========================================
  Files             44        44           
  Lines           1480      1480           
===========================================
  Hits            1480      1480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mishac
Copy link

mishac commented Nov 29, 2023

Any idea when this will be able to be merged? It's our last dependency we need before moving to symfony 7. Happy to help in any way if I can.

@VincentLanglet
Copy link
Owner Author

One day or two. I wait for a release of composer-unused/composer-unused#590 (comment)

@mishac
Copy link

mishac commented Nov 29, 2023

great thanks!

@VincentLanglet
Copy link
Owner Author

I also need composer-unused/symbol-parser#121

@VincentLanglet
Copy link
Owner Author

Now, I need maglnet/ComposerRequireChecker#458

which seems block by psalm and infection

@VincentLanglet VincentLanglet merged commit 9a4960d into main Dec 3, 2023
14 checks passed
@VincentLanglet VincentLanglet deleted the symfony-7 branch December 3, 2023 18:58
@OskarStark
Copy link

Would love to see a release 😃

@VincentLanglet
Copy link
Owner Author

Would love to see a release 😃

I made a lot of refacto on this lib, with some BC break, so it's required to be a 2.0.0
Would you be ok to test the main branch on your side @OskarStark (I can make a RC release if needed).

@VincentLanglet
Copy link
Owner Author

@mishac @OskarStark I released 2.0.0-rc-1, please tell me if everything is fine on your side :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants