Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade grpc dependency to >= 1.65.1 to avoid grpc corruption #540

Open
adriaanm opened this issue Sep 11, 2024 · 4 comments
Open

upgrade grpc dependency to >= 1.65.1 to avoid grpc corruption #540

adriaanm opened this issue Sep 11, 2024 · 4 comments
Assignees
Labels
area/core The SDK's core code blocked Something is blocking this issue form progressing impact/broken Something that is difficult or impossible for some people to use kind/internal Work that is not visible to an external user P2 Bugs of moderate severity to be assigned to an engineer in the next iteration size/S Estimated effort to complete (1-2 days).

Comments

@adriaanm
Copy link

Just ran into grpc/grpc-java#11284 today because I had some other dependency along with besom that bumped netty to 4.1.111.

The error I saw was:

ERROR besom.internal.ResourceDecoder.resolve:97
 Resolve resource: received error from gRPC call: 'INTERNAL: Encountered end-of-stream mid-frame', failing resolution
 2024.09.11 06:36:46:161 main  ERROR besom.internal.BesomModule.run:70
   io.grpc.StatusRuntimeException: INTERNAL: Encountered end-of-stream mid-frame

resolved for now by downgrading that dependency to get back to an older netty

@lbialy
Copy link
Collaborator

lbialy commented Sep 25, 2024

Hi @adriaanm, could you tell me how did you arrive in a situation where another dependency brought netty to the classpath of a besom program?

I'd gladly bump grpc deps but we do seem to have a little dependency problem in that area and I can recall that we could only bump them to versions that did not lead to scalapb explosion in runtime. I'll take another look tomorrow.

@adriaanm
Copy link
Author

adriaanm commented Oct 15, 2024

Sure, it happened when I bumped this dependency: "software.amazon.awssdk" % "eks" % "2.25.70" (<-- this one works, but the 2.27.x series does not)

@lbialy
Copy link
Collaborator

lbialy commented Oct 21, 2024

@prolativ just hit this (the same route btw - AWS SDK) and we've went through whether we can bump deps for 0.4.0 and have this done but it turns out the latest stable scalapb - 0.11.17 has a dependency on io.grpc » grpc-protobuf | 1.62.2 and I recall that before 0.3.2 I tried to unbork that manually, bumped the grpc deps manually and then everything went red in integration tests.

seems we're blocked until scalapb 1.0.0 comes out, the alpha release is using 1.68.0 so it should allow for successful use of netty 4.1.111.Final underneath.

@lbialy lbialy added the blocked Something is blocking this issue form progressing label Oct 21, 2024
@lbialy lbialy self-assigned this Oct 21, 2024
@lbialy lbialy added area/core The SDK's core code impact/broken Something that is difficult or impossible for some people to use size/S Estimated effort to complete (1-2 days). kind/internal Work that is not visible to an external user P2 Bugs of moderate severity to be assigned to an engineer in the next iteration labels Oct 21, 2024
@prolativ
Copy link
Collaborator

It seems like the last version of AWS SDK not affected by this problem is 2.26.9 (tested with "software.amazon.awssdk" % "lambda")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core The SDK's core code blocked Something is blocking this issue form progressing impact/broken Something that is difficult or impossible for some people to use kind/internal Work that is not visible to an external user P2 Bugs of moderate severity to be assigned to an engineer in the next iteration size/S Estimated effort to complete (1-2 days).
Projects
None yet
Development

No branches or pull requests

3 participants