refactor: redesign the IR tree in order to allow its mutability #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `with` statements fits into `Expr` without increasing its size.
plusvic
added a commit
that referenced
this pull request
Oct 28, 2024
With this change the IR tree is represented by a vector of `Expr`. References to other expressions in the tree are represented by the index of the expression in the vector.
tarekk22-afk
approved these changes
Nov 6, 2024
tarekk22-afk
approved these changes
Nov 6, 2024
tarekk22-afk
approved these changes
Nov 6, 2024
tarekk22-afk
approved these changes
Nov 8, 2024
tarekk22-afk
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change the IR tree is represented by a vector of
Expr. References to other expressions in the tree are represented by the index of the expression in the vector.