Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint does not support plugins as dependencies of shared configs #2

Open
Weetbix opened this issue May 24, 2019 · 0 comments
Open

Comments

@Weetbix
Copy link
Contributor

Weetbix commented May 24, 2019

Currently:

  • Try adding eslint-config-vivy to an NPM project
  • If/when the eslint-config-vivy dependency gets installed, the plugins can be installed in the sub node modules folder, ie:
    • <root>/node_modules/eslint-config-vivy/node_modules/eslint-plugin-prettier
  • Then running ESLint breaks as it cannot find the plugin:
Oops! Something went wrong! :(

ESLint: 5.16.0.
ESLint couldn't find the plugin "eslint-plugin-prettier". This can happen for a couple different reasons:

This is discussed here: eslint/eslint#3458
and RFC here:
eslint/rfcs#5

Note: this is not an issue with yarn most of the time due to the flatter hierachy.

One option is to add these plugins as peer dependencies, bu that kind of sucks.
I think we should just leave this for now as internally we are using yarn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant