Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AggAllParticipants doesn't need dates #46

Open
jgbarah opened this issue Jan 30, 2014 · 2 comments
Open

AggAllParticipants doesn't need dates #46

jgbarah opened this issue Jan 30, 2014 · 2 comments
Labels

Comments

@jgbarah
Copy link
Member

jgbarah commented Jan 30, 2014

Currently, AggAllParticipants in ITS.R is called as:

AggAllParticipants (startdate, enddate)

but it doesn't seem to use (nor needs) dates at all. If I'm right, those two arguments should be removed.

@dicortazar
Copy link
Member

Well, at some point that function should calculate all participants between two days. So far this is only calculating that value for the whole project.

@jgbarah
Copy link
Member Author

jgbarah commented Jan 30, 2014

In that case, I guess it should have at least a comment, stating the reason, but probably default values for each parameter, which could be NA, so that it can be used without parameters when needed (which is now always).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants