Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimble file should avoid @#head versions #45

Open
c-blake opened this issue Aug 27, 2020 · 4 comments
Open

nimble file should avoid @#head versions #45

c-blake opened this issue Aug 27, 2020 · 4 comments
Assignees

Comments

@c-blake
Copy link

c-blake commented Aug 27, 2020

See c-blake/hldiff#1 (comment) & subsequent.

Your requires sdl2_nim@#head seems to have been put in place and just stuck there since January 2017. 32f7b03e4001885346127b5e7e5d3deaedb2f834 seems to be the appropriate sdl2_nim git hash if you want that version, or else some release since then would likely be better.

@Vladar4
Copy link
Owner

Vladar4 commented Aug 30, 2020

So how do I suppose to refer to the latest version of the sdl2_nim then if not with #head?

Changing ng2 nimble file each time I release a new bugfix for the sdl2_nim seems highly inefficient.

@c-blake
Copy link
Author

c-blake commented Aug 30, 2020

I sympathize with you not wanting to have frequent z releases in sdl2_nim-x.y.z, but since -- once installed -- nimble never updates an foo-#head install according to the nimble maintainers, this feature is not achieving what you actually want. Your end users need to always rm -rf .nimble/pkgs/sdl_nim-#head before installing nimgame2 (or anything else that depends on sdl2_nim@#head). If they don't they could be stuck in the distant past, and I think that is not common knowledge among nimble users. So, I think at least with the current nimble frequent z releases is your best bet. Tagging @genotrance for his recommendation. I was personally stunned that foo-#head is never updated as this is almost exactly the opposite of what is useful/expected (though it might become an expense end users would complain about).

@genotrance
Copy link

See nim-lang/nimble#318. Nimble doesn't have lock files yet though an implementation is in the [works (https://github.com/nim-lang/nimble/issues/127). But who knows when that 5k diff will get merged.

Meanwhile, note that nimgame2 is also a library so it's lock file, if you decide to create one, will only apply to its tests, not to an end user who would need create their own lock file as well.

Nimble already installs the latest version of a package even if the required version is now old. #head just keeps your users stuck to one in the past.

@Vladar4
Copy link
Owner

Vladar4 commented Aug 30, 2020

Yeah, that's kinda counter-intuitive behavior.
I'll keep this open for now, will implement in the upcoming release.

@Vladar4 Vladar4 self-assigned this Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants