Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add V0 Modesty Mesh #1011

Closed

Conversation

MapleLeafMakers
Copy link
Collaborator

@MapleLeafMakers MapleLeafMakers commented Dec 21, 2023

  • The mod, firmware configuration or slicer profile is in the correct category
    folder. Printable mods go to printer_mods/, firmware configurations
    go to firmware_configurations/, slicer profiles go to slicer_profiles/.
    Create a subfolder with your name, and place the mods in a subfolder with
    a descriptive name within that folder, e.g.: /printer_mods/FHeilmann/flux_capacitor
  • Folder and file naming:
    • Folders and filenames shouldn't contain spaces. Only letters a-zA-Z, numbers 0-9, underscores _, hyphens - and periods .
    • Primary color: part_xyz.stl
    • Accent color: [a]_part_xyz.stl
    • Opaque color (Blocks light): [o]_part_xyz.stl
    • Clear/transparent color (Allows light): [c]_part_xyz.stl
    • Quantity, if more than one is needed: part_xyz_x4.stl
  • For each mod, add a small README.md file to its folder with a short description
    of what the mod accomplishes. This readme can be used to add pictures, give assembly
    instructions or specify a bill of materials if the mod requires additional hardware.
  • The PR modifies the top-level README.md of the category folder adding the
    contribution to the table. Read the top part of the file for instructions on how
    to do this. Please preserve the alphabetical ordering while adding new rows. Make sure
    to fill out the compatibility matrix to indicate which versions of the Voron printer
    the submission is compatible with.
  • The mod/configuration/profile has been tested by the person submitting the mod
    and/or other Voron users. Make sure to add information about how the mod was tested below.
  • The mod is not merely a slight modification of an official Voron part, configuration
    or profile (i.e. an official Voron part with a few mm added or removed or a slicer profile
    which only modifies a few values). (When in doubt, contact one of the admins in the
    Voron discord before submitting the PR)
  • Submitted STLs are printable without support. (If the mod does not meet this criterion
    join the Voron discord and ask the other users for advice on how to modify the mod such
    that it does not require supports)
  • Submitted STL files are not corrupt. (This can be tested by opening the STL in PrusaSlicer
    and checking if mesh errors are reported.)
  • Submitted STL files are oriented and scaled properly for printing.
  • Submission includes a CAD file in the form of a .STEP or .SCAD file
  • Submitted firmware configs or slicer profiles contain no sensitive data (e.g. API keys).

Which mods/configurations/profiles are added by this PR?

The V0 Modesty Mesh mod

How was it tested?

It's super popular, everyone loves it.

Any background context you want to provide?

no

Screenshots (if appropriate)

Further notes

Copy link

github-actions bot commented Dec 21, 2023

Hi, thank you for submitting your PR.
Please find below the results of the automated PR checker:

Added/Changed mods detected in this PR:

Item Result Description/Error Printer compatibility
MapleLeafMakers/Modesty_Mesh ✅ SUCCESS Customizable mesh inserts to hide your messy electronics compartment. V0

Tool check results overview:

Tool ⚠️ 💀
Whitespace checker 8 0 0 0
Mod structure checker 1 0 1 0
STL corruption checker 1 0 0 0
STL rotation checker 1 0 0 0
Readme generator 1 0 0 0

Tool check results details:

SUCCESS: ✅

Whitespace checker

Item Result Reason
MapleLeafMakers/Modesty_Mesh/LICENSE.md ✅ SUCCESS
MapleLeafMakers/Modesty_Mesh/README.md ✅ SUCCESS
MapleLeafMakers/Modesty_Mesh/.metadata.yml ✅ SUCCESS
MapleLeafMakers/Modesty_Mesh/STL/[a]_modesty_mesh_x2.stl ✅ SUCCESS
MapleLeafMakers/Modesty_Mesh/CAD/V0_Modesty_Mesh.step ✅ SUCCESS
MapleLeafMakers/Modesty_Mesh/Images/sliced.png ✅ SUCCESS
MapleLeafMakers/Modesty_Mesh/Images/parts.png ✅ SUCCESS
MapleLeafMakers/Modesty_Mesh/Images/render.png ✅ SUCCESS

Mod structure checker

Item Result Reason
MapleLeafMakers/Modesty_Mesh ✅ SUCCESS

STL corruption checker

Item Result Number of STL fixes applicable
[a]_modesty_mesh_x2.stl ✅ SUCCESS 0

STL rotation checker

Item Result Original orientation Suggested orientation
[a]_modesty_mesh_x2.stl ✅ SUCCESS

WARNING: ⚠️
FAILURE: ❌

Mod structure checker

Item Result Reason
MapleLeafMakers/Modesty_Mesh/images/render.png ❌ FAILURE The file is listed in the metadata.yml file but does not exist

EXCEPTION: 💀

I am a 🤖, this comment was generated automatically!

Made with ❤️ by the VoronDesign GitHub Team

@FHeilmann
Copy link
Contributor

Thanks for helping with the testing!

@FHeilmann FHeilmann closed this Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants