Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to create directories with the same names as files #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

twilight-sparkle-irl
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #1 into master will decrease coverage by 7.30002%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master          #1         +/-   ##
===================================================
- Coverage   78.20256%   70.90254%   -7.30002%     
===================================================
  Files             57          57                 
  Lines           4996        4997          +1     
===================================================
- Hits            3907        3543        -364     
- Misses          1089        1454        +365
Impacted Files Coverage Δ
src/fingerprints/BOOL/BOOL.c 0% <0%> (-100%) ⬇️
lib/libghthash/hash_functions_priv.h 0% <0%> (-100%) ⬇️
src/instructions/execute.c 0% <0%> (-80%) ⬇️
lib/libghthash/hash_table_priv.h 14.58333% <0%> (-34.58335%) ⬇️
src/instructions/iterate.c 65.21738% <0%> (-30.43479%) ⬇️
src/fingerprints/TURT/TURT.c 71.23287% <0%> (-22.26028%) ⬇️
src/fingerprints/FILE/FILE.c 67.14286% <0%> (-21.42858%) ⬇️
src/fingerprints/REFC/REFC.c 70.58824% <0%> (-20.58823%) ⬇️
src/instructions/io.c 68.57143% <0%> (-20%) ⬇️
src/fingerprints/DIRF/DIRF.c 80.76922% <0%> (-19.23078%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd908f...d7c12db. Read the comment docs.

@VorpalBlade
Copy link
Owner

VorpalBlade commented Nov 12, 2019

While this in principle looks good, I'm quite confused as to why it seems to break code coverage. That needs to be fixed before this can be merged.

EDIT: Aha, looking at the travis CI output it seems that it fails to run the tests at all:

https://travis-ci.org/VorpalBlade/cfunge/jobs/610594964:

[...]
Traceback (most recent call last):
  File "/home/travis/build/VorpalBlade/cfunge/tests/test_runner.py", line 110, in <module>
    main()
  File "/home/travis/build/VorpalBlade/cfunge/tests/test_runner.py", line 78, in main
    '-s', _SUFFIX_MAP[test_extension],
KeyError: 'b98_dir'
      Start  2: bounds.b98
 2/33 Test  #2: bounds.b98 .......................***Failed    0.11 sec
[...]

This is probably the cause of the issue. Why this doesn't cause the travis build to fail as well is strange (and something I'll try to look into when I have time).

Either way, as soon as the tests and code coverage is fixed it should be possible to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants