Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time-picker mode with setDateOnMenuClose sets modelValue to start-time even if nothing entered #1034

Open
jacobg opened this issue Nov 5, 2024 · 0 comments
Labels
awaiting triage The issue is not reviewed by the maintainers bug Something isn't working

Comments

@jacobg
Copy link

jacobg commented Nov 5, 2024

Describe the bug
Thank you for recently adding the setDateOnMenuClose config option. It's very useful. As expected, when using date picker if nothing is typed or selected in the date picker, then closing the menu does not set modelValue. However in time-picker mode, it does set the modelValue to start-time even though no time was typed or selected. Note that start-time is still useful to display an initial value in the selector (e.g., 00:00 instead of default current time), but not expected to be used if user doesn't select it or type anything.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://stackblitz.com/edit/vuepic-vue-datepicker-pkxtkx?file=src%2Fcomponents%2FPlayground.vue
  2. Click on input to open picker menu.
  3. Clock outside menu to close it.

Expected behavior
Neither modelValue nor input box should be set with value.

Actual behavior
It is setting the value to the start-time value.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop & mobile (please complete the following information):

  • Browser [e.g. chrome, safari]
  • Library version [e.g. 3.0.0]
@jacobg jacobg added awaiting triage The issue is not reviewed by the maintainers bug Something isn't working labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage The issue is not reviewed by the maintainers bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant