Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔎 Simple search #2

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

🔎 Simple search #2

wants to merge 6 commits into from

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Dec 2, 2024

Simple search

Super simple OV example.

  • Hits
  • Highlights
  • Suggestions
  • NoResults

Misc

  • The EmptyQueryBoundary does not work as described in the Instantsearch documentation. Comments are included
  • All other search components have been stripped from this example (AAPB search)
  • Upgrades package.json dependencies
  • Adds vite to dev dependencies

@mrharpo mrharpo requested review from afred and foglabs December 2, 2024 23:48
@mrharpo mrharpo self-assigned this Dec 2, 2024
@mrharpo mrharpo added breaking 💔 Breaking changes enhancement ➕ New feature or request maintenance 🔧 Updates and upgrades test 🧪 Tests and testing dependencies Pull requests that update a dependency file labels Dec 2, 2024
Copy link

gitguardian bot commented Dec 9, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9607557 Triggered Generic High Entropy Secret 1854cf7 app/data/searchkit.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking 💔 Breaking changes dependencies Pull requests that update a dependency file enhancement ➕ New feature or request maintenance 🔧 Updates and upgrades test 🧪 Tests and testing
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

1 participant