Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference Designator for search #420

Merged
merged 6 commits into from
Jul 1, 2021
Merged

Reference Designator for search #420

merged 6 commits into from
Jul 1, 2021

Conversation

sbatchelder
Copy link
Collaborator

Applied @MarioCarloni 's new Reference Designator model to value-change search, and added refdes querying options to inventory and action search.

There's an initial deployment-value-change interface for #391 as well based on the Deployment Export feature.

There was a typo bug in the roundabout/core/updaters.py: _create_reference_designators() function as well which is now fixed too. See the 04e8155 "refdes minifixes" commit below

Copy link
Collaborator

@MarioCarloni MarioCarloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd made the same fix to the refdes model as you, but that's fine, I'll be sure to merge your change downstream.

@ethanandrews ethanandrews merged commit 6db550c into release-1.7.0 Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants