Escape/Esc key locking

[craigfrancis]

I'm very uncomfortable with this API locking the [esc] key.

I can see that Special Considerations with the Escape Key have been made (ref issue 45), where:

...the user agent shows a user message "Press ESC to exit fullscreen" when
Javascript-initiated fullscreen is activated, then that message will need to
be updated when keyboard lock is in effect to read "Press and hold ESC 
to exit fullscreen".

I highly doubt users will read/notice a standard message that will typically disappear within a few seconds... but there is still a chance that users will press the [esc] key to escape from whatever full-screen thing they have fallen in to (I doubt many will continue to hold for 2 seconds).

Personally I want the Escape key to be excluded from this feature... I believe it should always Escape the view the user is currently in.

[craigfrancis]

This is the differences between the messages on Chrome, as of Beta 68:

I don't think many people will see the difference (if they are used to the old message), or will remember what to do (if they are new to full screen web pages).

[craigfrancis]

Just as a note on the Chrome implementation from Dominick Ng...

1. It re-shows the "Press and hold [esc] to exit full screen" message when pressing the [esc] key multiple times.

2. An "X" icon/button appears at the top of the screen after holding the [esc] key for 1000ms.

I like the first one, but believe the second should be improved as bit... get it to fade in at 250ms (1 second is far too long), and have it show a progress bar of some kind (so users know something is happening)... something like this rough/ugly screenshot:

---

That said... I'm still not convinced "webkitRequestFullscreen()" should be callable by the website, I'd much rather have the green dot (on MacOS) and a global shortcut (e.g. ctrl+cmd+F) be the only way to trigger full screen mode (i.e. part of the standard browser UI), where developers can register for a fullscreen event that allows them to specify which element on the page should be made full screen.

And... why do "games, editors, and remote desktop clients" within a web browser specifically need the Esc key... surely even vim can map that one key to something else (this keyboard lock feature basically allows the website developers to choose any other key)... I can't imagine this single key mapping will be so important to developers that it stops them making these things available on the web (I think the use of ctrl/cmd/alt/tab are more relevant).