Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Move events from events.wisv.ch to ch.tudelft.nl/events #33

Merged
merged 3 commits into from
Nov 2, 2023
Merged

WIP: Move events from events.wisv.ch to ch.tudelft.nl/events #33

merged 3 commits into from
Nov 2, 2023

Conversation

JoepdeJong
Copy link
Contributor

@JoepdeJong JoepdeJong commented Oct 19, 2023 •
edited
Loading

  • Change contextPath to /events
  • Add /events to HTTPRoute of ch.tudelft.nl (36508e0)
  • Add ch.tudelft.nl/events to Connect clients
  • Redirect events.wisv.ch/* to ch.tudelft.nl/events/*
  • Update Mollie API key

@JoepdeJong
Copy link
Contributor Author

Waiting on new mollie API key

praseodym
praseodym reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@praseodym praseodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we also need a HealthCheckPolicy?

@JoepdeJong
Copy link
Contributor Author

Maybe we also need a HealthCheckPolicy?

Good one. While check when migrating if this is necessary. Idk if the forward needs a HealthCheckPolicy.

@JoepdeJong
Copy link
Contributor Author

Still waiting on mollie verification.

@JoepdeJong JoepdeJong merged commit 837da29 into main Nov 2, 2023
2 checks passed
@JoepdeJong JoepdeJong deleted the events-path branch November 2, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praseodym praseodym praseodym left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoepdeJong @praseodym