Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add company teams to the teams page #19

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Add company teams to the teams page #19

merged 1 commit into from
Nov 5, 2024

Conversation

verwoerd
Copy link
Collaborator

@verwoerd verwoerd commented Nov 4, 2024

localhost_1313_teams_ (3)

Making it a separate table did make the logos for company teams bigger, so this is the most decent solution I could come up with. :)

@verwoerd verwoerd requested a review from mpsijm November 4, 2024 16:07
@mpsijm
Copy link
Contributor

mpsijm commented Nov 4, 2024

RE table: oh well, this works 😂 Styling wise, the output looks good to me 🙂

Do we want the companies ordered by alphabet, by team number (current), or by sponsor status (platinum first)? 😛

@verwoerd
Copy link
Collaborator Author

verwoerd commented Nov 5, 2024

I don't mind either way, I thought this looked the most pleasing, but feel free to change it to alphabetical if that has your preference.

Copy link
Contributor

@mpsijm mpsijm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matters much either way, since there's only 5 companies. And since nobody else called out a preference in Slack, I'd rather merge this now so that this gets deployed, and we can always change later 😄

@mpsijm mpsijm merged commit 0ee6a3f into main Nov 5, 2024
1 check passed
@mpsijm mpsijm deleted the company-teams branch November 5, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants