Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1) a handful of test failures were from node.record instead of node.request #1

Open
Waazer opened this issue Jun 9, 2024 · 0 comments
Open

1) a handful of test failures were from node.record instead of node.request #1

Waazer opened this issue Jun 9, 2024 · 0 comments
Assignees
@Waazer

Comments

@Waazer
Copy link
Owner

Waazer commented Jun 9, 2024

  1. a handful of test failures were from node.record instead of node.request
  2. missed passing networkRecords to createTestTrace
  3. fixed difference re: requests from Fetch
  4. fixed difference re: data urls not having a resource size
  5. handle creating requests in a redirect chain better
  6. createTestTrace was putting initiator data on wrong event
  7. always produce network events in createTestTrace (since it impacts graph construction when doing cpu node linking)

ref GoogleChrome/lighthouse#15841

Originally posted by @connorjclark in GoogleChrome/lighthouse#16033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Waazer Waazer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Waazer