fix stable release pipeline

WalletConnect · Jun 5, 2024 · dd44624 · dd44624
1 parent fb09cbf
commit dd44624
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/.github/workflows/build-android-internal.yml b/.github/workflows/build-android-internal.yml
@@ -10,6 +10,7 @@ on:
 
 jobs:
   build_with_signing:
+    name: Build Android App Internal (beta)
     runs-on: macos-latest
 
     steps:
@@ -71,10 +72,6 @@ jobs:
 
         VERSION=`echo $(cat $VERSION_FILE) | sed "s/[^']*'\([^']*\)'.*/\1/"`
 
-        # # Change packageName in build.gradle
-        # sed -i '' 's/com.web3modal.flutterExample/com.web3modal.flutterExample.internal/g' android/app/build.gradle
-        # sed -i '' 's/com.web3modal.flutterExample/com.web3modal.flutterExample.internal/g' android/app/src/main/kotlin/com/example/sign/MainActivity.kt
-
         # Set versionName on gradle.properties
         awk -F"=" -v newval="$VERSION" 'BEGIN{OFS=FS} $1=="versionName"{$2=newval}1' $GRADLE_FILE > "$GRADLE_FILE.tmp" && mv "$GRADLE_FILE.tmp" $GRADLE_FILE
 
@@ -86,6 +83,7 @@ jobs:
 
         # Build Android app with flutter
         flutter build apk --build-name $VERSION --build-number $NEXT_BUILD --dart-define="PROJECT_ID=$PROJECT_ID" --release --flavor beta
+
     # Setup Node
     - name: Setup Node
       uses: actions/setup-node@v3

diff --git a/.github/workflows/build-android.yml b/.github/workflows/build-android.yml
@@ -10,6 +10,7 @@ on:
 
 jobs:
   build_with_signing:
+    name: Build Android App Release
     runs-on: macos-latest
 
     steps:
@@ -81,7 +82,7 @@ jobs:
         NEXT_BUILD=$(grep 'versionCode' $GRADLE_FILE | cut -d'=' -f2)
 
         # Build Android app with flutter
-        flutter build apk --build-name $VERSION --build-number $NEXT_BUILD --dart-define="PROJECT_ID=$PROJECT_ID" --flavor stable --release
+        flutter build apk --build-name $VERSION --build-number $NEXT_BUILD --dart-define="PROJECT_ID=$PROJECT_ID" --release --flavor stable
         
     # Setup Node
     - name: Setup Node
@@ -97,7 +98,7 @@ jobs:
       env:
         APP_ID: ${{ secrets.ANDROID_APP_ID }}
       run: |
-        firebase appdistribution:distribute app-release.apk --app $APP_ID --release-notes "Web3Modal Flutter stable release" --groups "flutter-team, javascript-team, kotlin-team"
+        firebase appdistribution:distribute app-stable-release.apk --app $APP_ID --release-notes "Web3Modal Flutter stable release" --groups "flutter-team, javascript-team, kotlin-team"
     - name: Notify Channel
       uses: slackapi/[email protected]
       env: