Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coinbase_wallet_sdk Dependency and AGP 8.x Compatibility #168

Closed
4ICTOTA opened this issue Aug 26, 2024 · 4 comments
Closed

coinbase_wallet_sdk Dependency and AGP 8.x Compatibility #168

4ICTOTA opened this issue Aug 26, 2024 · 4 comments
Labels
investigation Report that should be investigated question Further information is requested

Comments

@4ICTOTA
Copy link

4ICTOTA commented Aug 26, 2024

I'm using web3modal_flutter in my Flutter project, and I've encountered an issue when attempting to build the project with Android Gradle Plugin (AGP) version 8.x. The problem stems from the coinbase_wallet_sdk dependency, which is pulled in automatically as a transitive dependency.

The coinbase_wallet_sdk causes a build failure because it lacks a namespace entry in its build.gradle file, which is required for compatibility with AGP 8.x. This issue prevents me from using the latest Android Gradle Plugin, which I need for other dependencies and tools in my project.

Steps to Reproduce:

Add web3modal_flutter as a dependency in a Flutter project.
Use Android Gradle Plugin version 8.x in the build.gradle file.
Attempt to build the project.
Expected Behavior:

The project should build successfully with Android Gradle Plugin 8.x without any issues related to the coinbase_wallet_sdk dependency.

Actual Behavior:

The build fails with an error stating that namespace is not specified in the coinbase_wallet_sdk module's build.gradle file.

Environment:

Flutter SDK: 3.24.1
Dart SDK: 3.5.1
Android Gradle Plugin: 8.x
web3modal_flutter version: 3.3.3
Kotlin version: 2.0.20
Additional Context:

This issue could potentially be resolved by making the coinbase_wallet_sdk an optional dependency or by updating it to be compatible with the latest AGP requirements. Any assistance or guidance on how to proceed would be greatly appreciated.

@quetool
Copy link
Collaborator

quetool commented Aug 29, 2024

Hello @4ICTOTA! Thanks for the report, I'll share it with Coinbase team. This is related to this one #162

@quetool
Copy link
Collaborator

quetool commented Aug 29, 2024

Could you try adding this in your pubsepc?

dependency_overrides:
  coinbase_wallet_sdk:
    git:
      url: https://github.com/WalletConnect/wallet-mobile-sdk.git
      path: flutter
      ref: beba5b377e32554f5c00ee08c4df509d9078dbf1

@quetool quetool added question Further information is requested investigation Report that should be investigated labels Aug 29, 2024
@4ICTOTA
Copy link
Author

4ICTOTA commented Aug 29, 2024

Thanks a lot! Added it to my pubspec.yaml, and it's working great. Much appreciated!
+rep

@quetool
Copy link
Collaborator

quetool commented Aug 29, 2024

Thanks for confirming @4ICTOTA! I opened a PR to Coinbase team in regards of this
MobileWalletProtocol/wallet-mobile-sdk#357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigation Report that should be investigated question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants