Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: DELETE method is not part of methods allowed by CORS, when it is needed for unregistering #151

Closed
1 task done
devceline opened this issue Oct 13, 2023 · 0 comments · Fixed by #150
Closed
1 task done
Assignees

Comments

@devceline
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

calling DELETE /identity fails in the browser due to CORS policy not including DELETE method.

Expected Behavior

calling DELETE /identity from the browser should succeed

Steps To Reproduce

In a browser environment, for example a console and running

fetch("https://keys.walletconnect.com/identity", { method: "DELETE" })

produces a CORS error, while running

fetch("https://keys.walletconnect.com/identity", { method: "GET" })

succeeds.

Environment

- OS:Linux
- rustc:N/A
- cargo:N/A

Relevant log output

Access to fetch at 'https://keys.walletconnect.com/identity?publicKey=thing' from origin 'https://jasonwatmore.com' has been blocked by CORS policy: Method DELETE is not allowed by Access-Control-Allow-Methods in preflight response.

Anything else?

No response

@devceline devceline self-assigned this Oct 13, 2023
@devceline devceline linked a pull request Oct 13, 2023 that will close this issue
3 tasks
@devceline devceline mentioned this issue Oct 13, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant