Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly include moshi with generated adapters #16

Open
4 tasks
rmeissner opened this issue Jul 16, 2019 · 0 comments
Open
4 tasks

Properly include moshi with generated adapters #16

rmeissner opened this issue Jul 16, 2019 · 0 comments

Comments

@rmeissner
Copy link
Collaborator

rmeissner commented Jul 16, 2019

To avoid issues as in #14 (partial fix with #15) we should use proper objects with moshi and generate adapters. These adapters will skip unknown values and known values are properly type checked.

ToDos

  • Add moshi code generation
  • Create data class for web socket message to bridge
  • Check current parsing logic and potentially create more data classes
  • Create a json parser interface and abstract away moshi in all classes to allow replacement by other json parsers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant