Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] modal close error causes subsequent connection attempts to fail #40

Open
2wheeh opened this issue Dec 3, 2024 · 0 comments · May be fixed by #41
Open

[bug] modal close error causes subsequent connection attempts to fail #40

2wheeh opened this issue Dec 3, 2024 · 0 comments · May be fixed by #41
Labels
bug Something isn't working

Comments

@2wheeh
Copy link

2wheeh commented Dec 3, 2024

Link to minimal reproducible example

https://lab-walletconnect-modal.pages.dev/with-sign-api/react

Summary

connection attempts following Modal closed error continue to throw the same error even when the connection is established. we can infer the session is connected because after a page refresh, it retrieves the session successfully.

2024-12-03.11.16.23.mov

List of related npm package versions

v2.6.2 (same in v2.7.0)
@2wheeh 2wheeh added the bug Something isn't working label Dec 3, 2024
@2wheeh 2wheeh linked a pull request Dec 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correct error handling in connect method 2wheeh/modal
1 participant
@2wheeh