Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get notifications analytics #410

Merged
merged 10 commits into from
Mar 12, 2024
Merged

fix: get notifications analytics #410

merged 10 commits into from
Mar 12, 2024

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Mar 11, 2024 •
edited
Loading

Description

Adds analytics for get notifications calls as per the linked issue.

Resolves #409

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Mar 11, 2024
@chris13524 chris13524 marked this pull request as ready for review March 11, 2024 23:47
@chris13524
Copy link
Member Author

chris13524 commented Mar 12, 2024 •
edited
Loading

Merging to start gathering some data overnight. If there are any issues, we can easily fix and clear the already written data.

@chris13524 chris13524 merged commit 46fb200 into main Mar 12, 2024
13 checks passed
@chris13524 chris13524 deleted the 409-analytics-for-get-notifications branch March 12, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekbrother geekbrother Awaiting requested review from geekbrother

@dnul dnul Awaiting requested review from dnul

@nopestack nopestack Awaiting requested review from nopestack

Assignees

@chris13524 chris13524

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analytics for get notifications
1 participant
@chris13524