From 80287444f347d5704d1302f3c69bb077a39b4c87 Mon Sep 17 00:00:00 2001 From: Max Kalashnikoff Date: Wed, 18 Oct 2023 23:16:32 +0200 Subject: [PATCH] fix: `notification` variable is encoded as a string, fix alert thresholds (#231) --- terraform/monitoring/main.tf | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/terraform/monitoring/main.tf b/terraform/monitoring/main.tf index 3b5f3164..4bfb899e 100644 --- a/terraform/monitoring/main.tf +++ b/terraform/monitoring/main.tf @@ -547,7 +547,7 @@ resource "grafana_dashboard" "at_a_glance" { { "evaluator" : { "params" : [ - 5 + 1 ], "type" : "gt" }, @@ -570,7 +570,7 @@ resource "grafana_dashboard" "at_a_glance" { { "evaluator" : { "params" : [ - 5 + 1 ], "type" : "gt" }, @@ -592,12 +592,11 @@ resource "grafana_dashboard" "at_a_glance" { } ], "executionErrorState" : "alerting", - "for" : "5m", "frequency" : "1m", "handler" : 1, "name" : "${var.environment} Echo Server 5XX alert", - "noDataState" : "no_data", - "notifications" : jsonencode(local.notifications) + "noDataState" : "keep_state", + "notifications" : local.notifications }, "datasource" : { "type" : "cloudwatch",