-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[specs] Support "dev" environment for sample apps #151
Comments
How should we treat the |
Answered in the SDK meeting:
|
On the Swift call today we discussed Github secrets where we can set variables like project ID to be run with github actions. Might be helpful? https://docs.github.com/en/actions/security-guides/encrypted-secrets#about-encrypted-secrets The infra team is using Github Secrets for the api proxy integration tests. |
Have separate sample apps for both dev and prod environments with separate relayUrl and projectId as environment variables |
just received report of a dev trying to use our Swift SDK with the "relay.dev.walletconnect.com" because it was on the example
https://github.com/WalletConnect/WalletConnectSwiftV2/blob/5ea0265d34f18ec48d71fc299adacecdacc904bb/Example/DApp/ClientDelegate.swift#L17
it's not terrible but we should have this default to the production server with some override value that you can change for testing environment
Status
Updated in:
The text was updated successfully, but these errors were encountered: