-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blockchainAPI): bundler interaction API #246
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
``` | ||
|
||
List of supported `method` values: | ||
* `sendUserOperation` - Sends a user operation to the given EVM network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since method names differ in different bundlers (not all, but some) we can unify them as I did here (and convert to the bundler-specific at the server-side) or pass the method through without any changes to the designated bundler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need support for wallet_getCallsStatus and wallet_showCallsStatus, Im not aware if we need the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geekbrother please add wallet_getCallsStatus
to the supported list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we also need to add: wallet_sendCalls
, or how the client sends the batch to the designated bundler? I believe this should be also done by our endpoint?
cc @llbartekll @jakubuid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ganchoradkov what's the implementation here? I thought that wallet is responsible for executing an atomic batch on it's own and this endpoint is for dapp to call for a status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the API: we will allow just wallet_getCallsStatus
and wallet_showCallsStatus
operations for now.
``` | ||
|
||
List of supported `method` values: | ||
* `sendUserOperation` - Sends a user operation to the given EVM network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need support for wallet_getCallsStatus and wallet_showCallsStatus, Im not aware if we need the others.
``` | ||
|
||
List of supported `method` values: | ||
* `sendUserOperation` - Sends a user operation to the given EVM network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
List of supported `method` values: | ||
* `wallet_getCallsStatus` - Returns the status of a call batch that was sent via `wallet_sendCalls`. | ||
* `wallet_showCallsStatus` - Requests that a wallet shows information about a given call bundle that was sent with `wallet_sendCalls`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the current demo PoC, we're fetching eth_getUserOperationReceipt
are we going to support it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's support it for a demo. Updated by adding eth_getUserOperationReceipt
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add this operation also if needed. Let's support it for now. I have added it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, the api is used now in WalletConnect/walletconnect-monorepo#5171 and reown-com/appkit#2666 💯 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds a bundler interaction API to the Blockchain-API new
/v1/bundler
endpoint. The user can choose the bundler to call and pass the json-rpc operation to the designated bundler.