Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imporve error handling #419

Open
enesozturk opened this issue Jan 26, 2024 · 1 comment
Open

Imporve error handling #419

enesozturk opened this issue Jan 26, 2024 · 1 comment

Comments

@enesozturk
Copy link
Contributor

enesozturk commented Jan 26, 2024

Description

We could give better feedback to the user when certain actions throw errors:

When registerIdentity throws an error, which is caught by Sentry:

Provided an invalid signature. Signature ${signature} by account ${accountId} is not a valid signature for message ${message}

We can see the error in the console but no actions taken or feedback shown to the user.

Steps to reproduce

  • Open app.web3inbox.com
  • Connect
  • Register account with invalid signature (can be achieved by overriding the function on dev mode)
@enesozturk
Copy link
Contributor Author

Quite much users having the following error:

Error: Error fetching featured projects: TypeError: Failed to fetch

Fetching errors could be for several reasons:

  • Network Issues: The problem might be related to network issues either on the server or the client side.
  • Endpoint Availability: Sometimes, endpoints may be down or unresponsive, leading to such errors.
  • CORS Configuration: The error might be due to subtle misconfigurations, such as incorrect headers or not allowing specific methods.
  • Client-Side Issues: If users are running outdated browsers or have certain extensions that interfere with network requests, these could lead to such errors.
  • Server Configuration: Things like SSL/TLS configuration, firewalls, and rate limiting which might block or alter requests.

As I took a glance at our fetch requests, we have a correct setup of CORS and API URLs, and no issue determined at this moment.

So this might be due to other reason (user might have network issues, some browser extensions might cause it, etc). Let's improve our error handling with better user message so they know what's going on if this error occurs again.

Moving this issue to Archive on Sentry for now with a event count limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant