Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leftover files from the past? #9

Open
kristapsk opened this issue Aug 29, 2023 · 9 comments
Open

Leftover files from the past? #9

kristapsk opened this issue Aug 29, 2023 · 9 comments

Comments

@kristapsk
Copy link
Contributor

What's the purpose of cloudflare.html and onion-index.html? Leftovers from the past? They are not configured nor linked anywhere. Although onion-index.html as an alternative index.html for Tor could be useful in context of #7 (but currently isn't).

@molnard
Copy link
Contributor

molnard commented Aug 29, 2023

I don't know. It would be good to check who created them and ask. Maybe with Git blame? (I hope it won't turn out I created them :D )

@kristapsk
Copy link
Contributor Author

  1. cloudflare.html was added by @CAnorbo in Loading page WalletWasabi#9459 and later updated in [website] Google meta, email signature, 404 page WalletWasabi#10137, but I don't see it configured in CloudFlare. Should be custom JavaScript Challenge page.

  2. With onion-index.html it's more fun - 2.0 website WalletWasabi#8373 by @CAnorbo adds it as a file, but removes using it from WalletWasabi.Backend/Controllers/HomeController.cs.

@molnard
Copy link
Contributor

molnard commented Aug 31, 2023

ExplosionBoomGIF

@CAnorbo
Copy link
Contributor

CAnorbo commented Sep 4, 2023

cloudflare.html is added but never configured on Cloudflare, It's a loading screen to avoid that ugly default one but, since we are not using that, we don't need this file either.

onion-index.html just stayed here from the previous website logic, if it isn't needed, because we are using the index.html on Tor, it's removable as the cloudflare.html.

@kristapsk
Copy link
Contributor Author

kristapsk commented Sep 4, 2023

cloudflare.html is added but never configured on Cloudflare, It's a loading screen to avoid that ugly default one but, since we are not using that, we don't need this file either.

We could start using it, I see no problems with configuring that at Cloudflare. But somebody needs to make sure it's up to date with design, etc.

@CAnorbo
Copy link
Contributor

CAnorbo commented Sep 5, 2023

cloudflare.html is added but never configured on Cloudflare, It's a loading screen to avoid that ugly default one but, since we are not using that, we don't need this file either.

We could start using it, I see no problems with configuring that at Cloudflare. But somebody needs to make sure it's up to date with design, etc.

Do we still have that Cloudflare challenge page on the website?

@kristapsk
Copy link
Contributor Author

Do we still have that Cloudflare challenge page on the website?

We use "managed challenge" which are kinda transparent from user perspective, but there is still possibility of various Cloudflare error pages.

@CAnorbo
Copy link
Contributor

CAnorbo commented Sep 5, 2023

Do we still have that Cloudflare challenge page on the website?

We use "managed challenge" which are kinda transparent from user perspective, but there is still possibility of various Cloudflare error pages.

If it's transparent we don't need that cloudflare.html the purpose of that was that we had an ugly countdown js challenge, so I made that better design but, we had no idea where and how to set it up, we didn't do that. Imho right now, it's a pointless file, so we can remove it.

@kristapsk
Copy link
Contributor Author

I have no strong objections against removing it.

But, FYI, these are custom pages CloudFlare allows to configure, maybe some of them could be useful:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants