Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic filling of occupied territory insides #159

Open
VictorSkr opened this issue Dec 8, 2024 · 5 comments
Open

Automatic filling of occupied territory insides #159

VictorSkr opened this issue Dec 8, 2024 · 5 comments

Comments

@VictorSkr
Copy link

It would be nice if there was a setting that when using Bluemap would give the possibility to automatically fill the interior of the territory as when using Dynmap.
Perhaps it would also be nice to add such an option that this autofill could be disabled when using Dynmap.
And also to make it so that when automatically filling the interior of the territory plugin counts and those chunks that are filled automatically.

Dynmap:
изображение
Bluemap:
изображение

@WasabiThumb
Copy link
Owner

Dynmap looks the way it does because the API does not support holes. BlueMap is showing the claim as it actually is.

@WasabiThumb
Copy link
Owner

WasabiThumb commented Dec 9, 2024

So to elaborate, the options are:

  • Dynmap team adds hole support, then XClaim can treat holes however it wants to
  • XC's Dynmap integration implements some kind of algorithm to split a shape with holes into multiple shapes with no holes, this would create lines inside of markers that are supposed to represent the same claim
  • XC's BlueMap integration adds a config option to ignore holes, in the process showing chunks that may not be claimed as claimed
  • XC adds an option to auto-fill claims when a perimeter is established, this may interplay strangely with features like limits & economy integration, could be used to make enormous server-hanging claims
  • Some combination of the above

Not sure what the best course of action is 🫤

@VictorSkr
Copy link
Author

Hmm... even I don't know which course of action would really be best for you.... Here is what I would probably do in the opinion of a person (me to be exact) who doesn't know programming, is to do the fourth action, as it seems to me it would be the best action, or in extreme case somehow do the third action

I may not be of any use to you in this case, sorry if I've given you a difficult task....

@VictorSkr VictorSkr reopened this Dec 9, 2024
@Paperboypaddy
Copy link
Contributor

  • XC adds an option to auto-fill claims when a perimeter is established, this may interplay strangely with features like limits & economy integration, could be used to make enormous server-hanging claims

I actually somewhat encountered this myself. I think option 4 is also a good alternative. Actually helps when selecting boundaries on an existing server new with this plugin. But maybe either ask the player if wanted to auto-fill, and/or if past limit then deny it since player doesn't have enough available.

@WasabiThumb
Copy link
Owner

Option 4 would be easy to implement with the v2 transaction system :)

@WasabiThumb WasabiThumb moved this to Todo in XClaim V2 Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants