Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: c2wwise forces plugin version to correspond to Wwise version #142

Open
eu-ch opened this issue Dec 2, 2023 · 4 comments
Open

Bug: c2wwise forces plugin version to correspond to Wwise version #142

eu-ch opened this issue Dec 2, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@eu-ch
Copy link
Contributor

eu-ch commented Dec 2, 2023

bundle_template.json sets targetWwiseVersion to be the same as plugin version, but it should be set based on parsing AkWwiseSDKVersion.h or $WWISEROOT/install-entry.json

    "id": "Heavy.{{name}}.${year}_${major}_${minor}_${build}",
    "name": "{{name}}",
    "tag": "{{name}}",
    "description": "",
    "vendor": "Heavy",
    "image": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII=",
    "type": "plugin",
    "productDependentData": {
        "targetWwiseVersion": {
            "year": ${year},
            "major": ${major}
        }
    },
@dromer dromer added the bug Something isn't working label Dec 2, 2023
@dromer
Copy link
Collaborator

dromer commented Dec 2, 2023

Hmm, not sure how we can decouple this. Perhaps we need a separate step for creating the bundle?

Because after your refactor the rest of the code no longer depends on a specific SDK right?

I'm not even sure what is even using bundle_template.json. c2wwise copies it over, but none of these fields have variables that can be used.

@eu-ch
Copy link
Contributor Author

eu-ch commented Dec 2, 2023

Copying my answer from discord. I can get version from certain files in the Wwise SDK folder (I've mentioned two possible options in the ticket). Bundle template us used for making installable bundles and it requires an image, so here you go 🙂 I can possibly include a hvcc logo there instead

bundle_template itself is turned into a bundle.json when making a package

@dromer
Copy link
Collaborator

dromer commented Dec 2, 2023

Ok, so this bundle template is used by the wwise SDK scripts, not by c2wwise?

@eu-ch
Copy link
Contributor Author

eu-ch commented Dec 2, 2023

Ok, so this bundle template is used by the wwise SDK scripts, not by c2wwise?

Correct. I just want making plugin bundles as frictionless as possible. It's a really useful feature of new build system and I liked using it in past projects.

I can just check do of files under $WWISEROOT of what's installed and fall back to using current setup. See install-entry.json under Wwise installation, it contains all metadata about installed SDK packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants