Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-format code with Black + Travis-CI. #25

Open
synchronizing opened this issue Jun 14, 2019 · 3 comments
Open

Auto-format code with Black + Travis-CI. #25

synchronizing opened this issue Jun 14, 2019 · 3 comments
Assignees
@synchronizing
Labels
📦 enhancement New feature or request 📍proposition Propose a change to the codebase. 🐍 python

Comments

@synchronizing
Copy link
Contributor

As discussed earlier in #23, this would be an excellent idea to ensure our code is auto-formatted on PR merge to master.
@synchronizing synchronizing added the 📦 enhancement New feature or request label Jun 14, 2019
@synchronizing synchronizing self-assigned this Jun 14, 2019
@synchronizing
Copy link
Contributor Author

This would need to be a custom bash script for us to be able to instantly commit code. Good reference can be found here.

@synchronizing synchronizing changed the title Auto-format code with Black. Auto-format code with Black + Travis-CI. Jun 30, 2019
@synchronizing synchronizing added 🐍 python 📍proposition Propose a change to the codebase. labels Jun 30, 2019
@Alescontrela
Copy link
Contributor

CryptoBook-js is tested for formatting in Travis CI. Shouldn't be that hard to implement with CryptoBook-py.

@synchronizing
Copy link
Contributor Author

CryptoBook-js is tested for formatting in Travis CI. Shouldn't be that hard to implement with CryptoBook-py.

Yeah, it would be a bash script away. It's not priority rn, so I'll just leave it as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@synchronizing synchronizing

Labels
📦 enhancement New feature or request 📍proposition Propose a change to the codebase. 🐍 python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@synchronizing @Alescontrela