Skip to content

Commit

Permalink
Use locale-independent sort to fix deterministic issues with ZIP
Browse files Browse the repository at this point in the history
As recommended in the Reproducible Builds's docs: https://reproducible-builds.org/docs/archives/#file-ordering
  • Loading branch information
Roboe committed Mar 4, 2019
1 parent dd5da9a commit 89f09c9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ $(FLASHABLEZIP): $(FIRMWARE_DIR) $(EDIFY_BINARY) $(EDIFY_SCRIPT)
@echo "Building flashable ZIP..."
@mkdir -pv "$(@D)"
@rm -f "$@"
@cd "$(TEMP_DIR)" && $(FIND) -type f | $(SORT) | $(ZIP) -X \
@cd "$(TEMP_DIR)" && $(FIND) -type f | LC_ALL=C $(SORT) | $(ZIP) -X \
"$(ROOT)/$@" -@
@rm -rf "$(TEMP_DIR)"
@echo "Result: $@"
Expand Down

0 comments on commit 89f09c9

Please sign in to comment.