Upload signed Firefox Addon to Store

[amenk]

The Firefox Addon from your website is not signed and hard to install.

Please fix :-)

[teh]

Yea, we know! FF is changing its extension model and I have a branch to fix: https://github.com/WeAreWizards/passopolis-extensions/tree/ff44

It's kinda working but still has a few rough edges. Once that's in we'll try to get it signed.

[amenk]

Estimate? Anything we could help? Is there a ticket for it?

[Neo2SHYAlien]

Hello from FF 48 there is no possible to use unsigned extension. @teh do you have any news for the signed version of the extension ?

[ZockerFloh7]

Any progress here?

[teh]

See - #13 and #36

I will merge that PR soon, and then try to get the signed extension into the addon store. We're only going to support Firefox 50+ though, because all the intermediate Firefox versions have bugs that can't really be worked around.

[Neo2SHYAlien]

@teh thank you very much for the update. This is great news. I'm looking for it.

[ZockerFloh7]

ah, ok
thanks for the update
your´re doing a great job!

[teh]

I got the first review and I need to remove some duplicate JS files before they'll accept the extension.

The removal is a bit tricky because the mitro devs took a few shortcuts. It'll take me a few days to fix.

[cosmicnet]

Using FireFox Developer Addition allows you to install the old extension. Or at least it did when the extension was still available on the passopolis site.

[teh]

If you want to give the new version (Firefox 52+) a try you should be able to get it from here:

https://addons.mozilla.org/en-US/firefox/addon/passopolis-login-manager/

Notes:

• I had to change a lot so I expect bugs. Please file new issues for Firefox bugs.
• I'm not sure how long the review will take. Until then the extension won't be publicly listed - use the link above.

[dbalbright]

Just curious, Firefox 50 is out and the above linked extension doesn't work? Do we have to use the developer preview just to use the signed extension?

[teh]

I believe so, yes, apologies. I'm still stuck in review because I need to source all files in the extension correctly. That is a bit of a faff because the original extension vendored files, so I'm still chasing some code.

[ZockerFloh7]

Hey, can you maybe reupload the current version, the link is down. And it would be nice if you could provide previous versions, i tested the current yesterday and it didnt work, the one before did, but now both are unavailable.

[teh]

@ZockerFloh7 - sadly that is out of my hands. The extension got rejected. I need to finish sourcing the files for the review which is an infinite time sink. I'll do it as soon as I have time but I can't make any promises.

[ZockerFloh7]

@teh - I understand, but maybe you can upload the not signed versions somewhere, some people might find this useful. Can I support your work somehow?

[serhat-io]

What is the status ?
Can we expect a release of the extension soon?

[amenk]

I need to finish sourcing the files for the review which is an infinite time sink.

what does that mean? can we help? what steps are you doing?

[jose-sanz]

Any news? Anything we can do?

[amenk]

How likely is it, that the extension will pass the review after modularizing and typing the code.
I still do not fully understand why it got rejected. What means "sourcing the files" ?

And would it be an option what @ZockerFloh7 suggested #30 (comment) ?

[amenk]

On the website is says "unsupported until firefox 50 is released" can you update that to "help wanted" or s.th. :-)

[ZockerFloh7]

@teh still alive? is there any progress?
i think here are many people willing to help you, including me.
this is a great project, but it needs to be developed further

[amenk]

I think according to what you wrote in #48 (comment) the improtant think to do is to modularize the extension and properly include external libraries such as jquery, right?
So this would go towards a requirejs including and requirejs config? Am I understanding that right?
(see also #49)

[amenk]

Is it maybe possible to share the rejection-results from Firefox here?

[teh]

Yea, I got:

Are really all of the files inside the extension used? Especially all the crypto and hashing libraries?
For all third party libraries, please provide a link to release version used in the original repository or website so we can verify the integrity.

[teh]

Apologies, wrong button 😕

[amenk]

But there is a lot of crypto in the extension, right? So the answer would basically be yes.. and then we have the externs_* files which we have to search in the internet ? - or better - I guess - include them via yarn or bower or webpack so the release references are stated clearly in the codebase ...

[teh]

There is a lot of crypto, yea. Some of it can probably now be replaced with browser built-ins, but the rest would probably best be referenced via a package manager as you say.

These review rounds are very long (6-10 weeks) because it's Mozilla volunteer time. So I want to have a solid case next time round, which blocks on modularization (flow checking is almost secondary, except that it helps us build confidence in the changes we made).

[amenk]

Not sure if so much can be done by the browser ... do you have an example? Are we talking about keyczar ? Isn't the passopolis more or less inventing it's on crypto (which might not be the best thing, but anyway's - it's a crypto product).
Not sure what is the aim of Mozilla's reviews? To not harm the browser by stealing sensitive data? i.e. that would mean they really have to review the full crypto, which could take lots of weeks in pure working time, I guess?

[johnnyasantoss]

I know that Firefox extensions is changing to WebExtensions API
Meanwhile this should be a possible workaround.
PS: I didn't tested, but It worked just fine in other extensions like Vue DevTools

[dbdr]

https://passopolis.com/install.html says:
"Firefox is temporarily unsupported until Firefox 50 has been released. You can follow this issue for updates."
Since Firefox 50 has long been released, it would be helpful to update that message with the current status.

[amenk]

@johnnyasantoss

Meanwhile this should be a possible workaround.

I think I tested it before .. AFAIR it does not seem to work

[rscircus]

Bump. I have a little bit of time at my hands. How can I help?

I have no background in developing extensions for Firefox, but for the "old" Opera Browser.

Anybody willing to guide/help a bit? Firefox Quantum made me come back to the Fox and Passopolis is the only plugin missing.

[NigelThorne]

Firefox 58 is out. Any chance to fix this?

[ispulkit]

Waiting for this thing guys .. :/

[Neo2SHYAlien]

Latest ESR is based on Firefox 60 and passopolis no longer will be available.