Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment creation code #42

Open
adeneys opened this issue Jun 25, 2013 · 1 comment
Open

Update comment creation code #42

adeneys opened this issue Jun 25, 2013 · 1 comment

Comments

@adeneys
Copy link
Contributor

adeneys commented Jun 25, 2013

The comment creation process currently traverses the content tree lookig for the post item by template. A better way to do this would be to look for the first non-comment and non-folder item in the ancestors. Makes this piece of code more flexible.

@adeneys
Copy link
Contributor Author

adeneys commented Aug 3, 2013

It looks like the only reason the current code looks for the blog item during comment creation is to read settings and determine the appropriate template to use for the comment item. We should extract the settings to a provider model where settings can be read from configuration or a blog item. That would allow creating comments on non-blog items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant