Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIT.md resource-method func-item expansion results in double semi colon #267

Closed
patrickhuber opened this issue Oct 26, 2023 · 2 comments · Fixed by #268
Closed

WIT.md resource-method func-item expansion results in double semi colon #267

patrickhuber opened this issue Oct 26, 2023 · 2 comments · Fixed by #268

Comments

@patrickhuber
Copy link
Contributor

Looking at the resource-method definition and func-item definition in the WIT.md, expanding the 'func-item' case results in the application of a double semi colon:

resource-method ::= func-item ';'
                  | id ':' 'static' func-type ';'
                  | 'constructor' param-list ';'

func-item ::= id ':' func-type ';'

I believe the resource-method definition should be changed to the following to avoid this as the func-item brings its own semi colon

resource-method ::= func-item
                  | id ':' 'static' func-type ';'
                  | 'constructor' param-list ';'

func-item ::= id ':' func-type ';'
@alexcrichton
Copy link
Collaborator

Thanks for spotting this! I've posted #268 with the fix you suggested.

@lukewagner
Copy link
Member

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants