Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elements in css should better be namespaced #101

Open
lomotelsch opened this issue Mar 9, 2016 · 0 comments
Open

elements in css should better be namespaced #101

lomotelsch opened this issue Mar 9, 2016 · 0 comments

Comments

@lomotelsch
Copy link

He Jeff,

I saw, that in your css, some styles are applied globally to some elements:

wcDocker.css
496: .fa-menu
501: .context-menu-submenu:after
621: .fa-pulse

Themes/default.css
156-173: .context-menu-*
196: input
201: select
205-232: button

With maintenance and scalibilty in mind, it would be nice to see these namespaced/wrapped with a .wcDocker-class or something, to bypass the need to edit your stylesheets or override these elements in my own stylesheet, since they are globally applied.

The html and body styles in line 18 also are very global and from my point of view they should only be mentioned in the tutorial-section instead of hardcoding them into the base css.

These are just some thoughts on how to bring more flexibilty into wcDocker...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant