Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/wdsbt 62 create block theme #47

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

itsamoreh
Copy link
Contributor

Closes

https://webdevstudios.atlassian.net/browse/WDSBT-62

Link to test

N/A

Description

Run a create block theme export and commit the changes.

"Save Style Changes"
"Save Template Changes"

These are really just formatting and organization changes. This will help avoid conflicts and excessive unrelated changes when using the Create Block Theme plugin on projects.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

N/A

Added to documentation?

  • 📜 README.md
  • 📓 Confluence
  • 🙅 No documentation needed

Added tests?

  • 👍 Yes
  • 🙅 No, because they aren't needed
  • 🙋 No, because I need help

Testing Instructions

  1. Double check and make sure that everything still works as expected

Reviewer's Testing Checklist

As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.

  • Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
  • Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
  • Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
  • Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
  • Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint). Check if PR passes code quality check.
  • Accessibility Testing: Validate that the changes comply with accessibility standards. Run npm run a11y.
  • Security Best Practices: Ensure that the code follows WordPress security best practices. Check if PR passes security check.
  • Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
  • Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

Copy link
Contributor

@thatmitchcanter thatmitchcanter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@thatmitchcanter thatmitchcanter merged commit 9e25aa7 into main Nov 6, 2024
3 of 4 checks passed
@thatmitchcanter thatmitchcanter deleted the chore/WDSBT-62-create-block-theme branch November 6, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants