Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "non standard parameters" warning doesn't show up after changing defaults in the developer mode #489

Open
julienw opened this issue Feb 26, 2025 · 1 comment
Open

The "non standard parameters" warning doesn't show up after changing defaults in the developer mode #489

julienw opened this issue Feb 26, 2025 · 1 comment
Labels
v3.1

Comments

@julienw
Copy link
Contributor

julienw commented Feb 26, 2025 •
edited
Loading

STR

  1. Open the benchmark with ?developerMode
  2. Open the developer menu
  3. click "unselect all"
  4. click "Perf-Dashboard"
  5. click "Start tests"

Actual

After the run, the results are shown without any warning.

Expected

After the run, the results are shown with the warning for "non standard parameters".

Cc @camillobruni
@julienw julienw added the v3.1 label Feb 26, 2025
@camillobruni
Copy link
Contributor

Just noticed that we actually don't display a warning if custom URL params are used without the &developerMode param.

@camillobruni camillobruni mentioned this issue Mar 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v3.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@camillobruni @julienw